Fix default style (svg width/height) & css prop on promotions #3185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 59b9292 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Size Change: +34 B (0%) Total Size: 1.59 MB
ℹ️ View Unchanged
|
hschawe
requested review from
TheSonOfThomp and
stephl3
and removed request for
a team
stephl3
reviewed
Oct 6, 2025
| <Badge variant={Variant.Green} className={badgeStyles}> | ||
| <Icon glyph="Award" /> | ||
| </Badge> | ||
| <Body as="span" {...rest}> |
There was a problem hiding this comment.
can we almost move this {...rest} to the outer div?
Comment on lines
12
to
14
| & div { | ||
| box-sizing: border-box; | ||
| } |
There was a problem hiding this comment.
Is this specifically for the badge element? If so, wondering if we can add directly to badgeStyles below
.changeset/curvy-lines-tie.md
Outdated
| @@ -0,0 +1,5 @@ | |||
| --- | |||
| '@lg-chat/message': minor | |||
There was a problem hiding this comment.
Since this is a backwards-compatible bugfix, this can be marked as a patch https://semver.org/#summary
There was a problem hiding this comment.
was thinking this could be considered a minor change due to the addition of className
There was a problem hiding this comment.
I would mark it minor if it was net-new, but in this case, it was already added and getting passed to the Body instance instead of the outermost div
| 'Challenge your knowledge by earning the Advanced Schema Design skill! This is a really really really really really really really really really long copy text to test how the component handles multiline text content.', | ||
| ], | ||
| promotionUrl: ['https://learn.mongodb.com/skills'], | ||
| className: [ |
There was a problem hiding this comment.
We don't typically generate story instances for demonstrating className overrides. Although we'll expose the className prop for components, it's typically an exception rather than a promoted feature to keep UI consistent
There was a problem hiding this comment.
fair! I thought it'd be useful to keep a content-box test case, but it might be more appropriate to test that on the Badge component anyway
|
Heads up @hschawe: I've updated where the This PR will likely require a rebase off main to account for this change |
stephl3
approved these changes
Oct 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✍️ Proposed changes
Fixes default style on Message.Promotion component. The style
box-sizing: border-boxwas missing, causing the promotion badge size to be wrong when implemented on the MongoDB Assistant. On Storybook,border-boxis set by default on all elements under the Story root element, so this issue was not caught previously.I've also made it possible for users to pass in custom styles on the promotions with
className, as it could be a helpful workaround for users if any similar issues arise.I also updated the stories:
classNameprop, passing differentbox-sizingon the promotion container.✅ Checklist
For bug fixes, new features & breaking changes
HTMLElementProps<'div'>is already documented in the readme]pnpm changesetand documented my changes🧪 How to test changes